feat: support all component types in interface #114
+38
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentkoppen
commented
Nov 12, 2025
Comment on lines
76
to
77
| for pgm_name in ComponentType: | ||
| if pgm_name in self._input_data and hasattr(self.grid, pgm_name): |
Member
Author
There was a problem hiding this comment.
Or do we prefer to just use:
Suggested change
| for pgm_name in ComponentType: | |
| if pgm_name in self._input_data and hasattr(self.grid, pgm_name): | |
| for pgm_name in self._input_data.keys(): | |
| if not hasattr(self.grid, pgm_name): | |
| continue |
Member
There was a problem hiding this comment.
I think I prefer current version. But both are fine
Signed-off-by: Vincent Koppen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #112
Changes proposed in this PR include:
Currently we have a hardcoded list of arrays to convert to input_data.
This PR relies on
ComponentTypefrom PGM as a complete set off possible values. This also allows user to add a new component before we do with a working interface layer.load_flowfile to easier find the interface in the code ;)